Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Popper): add support of prop zIndex #8091

Merged
merged 2 commits into from
Dec 17, 2024
Merged

fix(Popper): add support of prop zIndex #8091

merged 2 commits into from
Dec 17, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Dec 17, 2024 •
edited by inomdzhon
Loading

  • Release notes

Описание

Сейчас свойство zIndex компонента Popper работает некорректно.

Изменения

Поправил установку z-index в style в компоненте Popper

Release notes

Исправления

  • Popper: свойство zIndex теперь корректно устанавливает свойство z-index

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner December 17, 2024 09:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 388.98 KB (+0.02% 🔺)
JS (gzip) 118.05 KB (+0.06% 🔺)
JS (brotli) 97.26 KB (+0.15% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 341.44 KB (0%)
CSS (gzip) 42.28 KB (0%)
CSS (brotli) 33.67 KB (0%)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 17, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

inomdzhon
inomdzhon reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

аа это баг же был, поправил задачу на Bug и v7.0.1 выставил

а в PR добавил лейбел patch

packages/vkui/src/components/Popper/Popper.tsx Outdated Show resolved Hide resolved
@inomdzhon inomdzhon added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 17, 2024
@inomdzhon inomdzhon changed the title feat(Popper): add support of prop zIndex fix(Popper): add support of prop zIndex Dec 17, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.59%. Comparing base (5cb14c4) to head (80de259).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/components/Popper/Popper.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8091      +/-   ##
==========================================
- Coverage   95.60%   95.59%   -0.01%     
==========================================
  Files         398      398              
  Lines       11322    11326       +4     
  Branches     3729     3731       +2     
==========================================
+ Hits        10824    10827       +3     
- Misses        498      499       +1
Flag Coverage Δ
unittests 95.59% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov merged commit b5f950e into master Dec 17, 2024
26 of 28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/8067/popper-z-index-prop branch December 17, 2024 12:37
vkcom-publisher pushed a commit that referenced this pull request Dec 17, 2024
@EldarMuhamethanov @actions-user
fix(Popper): add support of prop zIndex (#8091)
da90d19 
* feat(Popper): add support of prop zIndex

* fix(Popper): make with mergeStyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees
No one assigned
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug][Popper]: добавить свойство zIndex
3 participants
@EldarMuhamethanov @inomdzhon @andrey-medvedev-vk